Prod - M2M and Other changes #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use dynamic m2m token instead static BUS token.
…checks required data by itself
…rMentionedUser even with current config it doesn't make any difference, but in theory it can
…gs and issue #38 - Refactor logic of email notification handling
…on event for first mention in the post
… settings apply to emails, revert some services to use m2m
Email bundle and refactoring
Feature/email settings
# Conflicts: # config/default.js # connect/config.js # connect/service.js # src/services/helper.js
deprecate static Admin token generation.
|
@gondzo Can you please take a look at this PR? We already have non m2m changes on production because we have to create a separate dev and master branch to deploy bundling changes (without getting partial m2m changes) to production. So, essentially this PR would send the same changes again to the production and should not cause any harm. But still want to have fresh eyes on it. |
|
looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.